rpc, server: add DRPC support for node join RPC #157993

cthumuluru-crdb · 2025-11-18T12:15:26Z

DRPC is currently disabled by default and can be enabled via the rpc.experimental_drpc.enabled cluster setting. Some code paths, such as command-line tools, don't have access to this setting. This change introduces a --use-new-drpc flag for start commands to enable DRPC in those cases. This change enables the use of DRPC for the node join RPC when the --use-new-rpc flag is set, and defaults to gRPC otherwise.

Epic: CRDB-55200, CRDB-51459
Fixes: #155592, #149600
Release note: None

blathers-crl · 2025-11-18T12:15:31Z

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}

cockroach-teamcity · 2025-11-18T12:15:45Z

This change is

github-actions · 2025-11-18T17:15:51Z

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

github-actions · 2025-11-20T05:05:50Z

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

github-actions · 2025-11-20T18:40:57Z

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

github-actions · 2025-11-20T18:42:35Z

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

DRPC is currently disabled by default and can be enabled via the `rpc.experimental_drpc.enabled` cluster setting. Some code paths, such as command-line tools, don't have access to this setting. This change introduces a `--use-new-drpc` flag for start commands to enable DRPC in those cases. Epic: CRDB-55200 Fixes: cockroachdb#155592 Release note: None

This change enables the use of DRPC for the node join RPC when the `--use-new-rpc` flag is set, and defaults to gRPC otherwise. Epic: CRDB-51459 Fixed: cockroachdb#149600 Release note: None

github-actions · 2025-11-24T03:40:57Z

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

github-actions · 2025-11-24T06:59:38Z

Potential Bug(s) Detected

The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.

Next Steps:
Please review the detailed findings in the workflow run.

Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.

After you review the findings, please tag the issue as follows:

If the detected issue is real or was helpful in any way, please tag the issue with O-AI-Review-Real-Issue-Found
If the detected issue was not helpful in any way, please tag the issue with O-AI-Review-Not-Helpful

shubhamdhama

LGTM! I wish some non-essential refactor of drpc.go could be done in a separate commit even if that's done in this PR. But now I have gone through the PR so it's fine here.

shubhamdhama · 2025-11-24T10:10:55Z

pkg/rpc/drpc.go

+// TODO(server): unexport this once dial methods are added in rpccontext.
+func DialDRPC(
+	rpcCtx *Context,
+) func(ctx context.Context, target string, _ rpcbase.ConnectionClass, additionalOpts ...drpcclient.DialOption) (drpc.Conn, error) {
+	return rpcCtx.drpcDialRaw
+}


Is this needed now?

shubhamdhama · 2025-11-24T12:20:35Z

pkg/rpc/rpcbase/nodedialer.go

 )

-var envExperimentalDRPCEnabled = envutil.EnvOrDefaultBool("COCKROACH_EXPERIMENTAL_DRPC_ENABLED", false)
+var envExperimentalDRPCEnabled = envutil.EnvOrDefaultBool("COCKROACH_EXPERIMENTAL_DRPC_ENABLED", true)


I see that the PR has do-not-merge label, still maintaining a checklist as a separate comment for things we should revert before we remove that label would be good.

shubhamdhama · 2025-11-24T12:28:04Z

pkg/rpc/drpc.go

 func (c *closeEntirePoolConn) Close() error {
-	_ = c.Conn.Close()
-	return c.pool.Close()
+	if c.closed.CompareAndSwap(false, true) {
+		_ = c.Conn.Close()
+		return c.pool.Close()
+	}
+
+	return nil
 }


This should go in a separate commit.

shubhamdhama · 2025-11-24T12:35:11Z

pkg/server/init.go

+		}()
+		initClient = kvpb.NewDRPCNodeClient(conn)
 	}



Maybe extract this to a new method.

cthumuluru-crdb added the do-not-merge bors won't merge a PR with this label. label Nov 18, 2025

cthumuluru-crdb force-pushed the issue-149600 branch from 7538369 to d833a9c Compare November 18, 2025 16:11

cthumuluru-crdb changed the title ~~wip: Issue 149600~~ rpc, server: add DRPC support for node join RPC Nov 18, 2025

cthumuluru-crdb changed the title ~~rpc, server: add DRPC support for node join RPC~~ rpc, server: add DRPC support for Node join RPC Nov 18, 2025

cthumuluru-crdb changed the title ~~rpc, server: add DRPC support for Node join RPC~~ rpc, server: add DRPC support for node join RPC Nov 18, 2025

cthumuluru-crdb force-pushed the issue-149600 branch from d833a9c to 04d753d Compare November 18, 2025 17:12

github-actions bot added the o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. label Nov 18, 2025

cthumuluru-crdb added O-AI-Review-Not-Helpful AI reviewer produced result which was incorrect or unhelpful and removed o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. labels Nov 18, 2025

cthumuluru-crdb force-pushed the issue-149600 branch from 04d753d to 4cf29a0 Compare November 20, 2025 01:41

github-actions bot added the o-AI-Review-Potential-Issue-Detected AI reviewer found potential issue. Never assign manually—auto-applied by GH action only. label Nov 20, 2025

cockroach-teamcity added the X-perf-gain Microbenchmarks CI: Added if a performance gain is detected label Nov 20, 2025

cthumuluru-crdb force-pushed the issue-149600 branch 2 times, most recently from 753afff to bd11b0a Compare November 20, 2025 18:38

cthumuluru-crdb added 2 commits November 24, 2025 08:35

rpc, server: add DRPC support for node join RPC

083ef76

This change enables the use of DRPC for the node join RPC when the `--use-new-rpc` flag is set, and defaults to gRPC otherwise. Epic: CRDB-51459 Fixed: cockroachdb#149600 Release note: None

cthumuluru-crdb force-pushed the issue-149600 branch from bd11b0a to 083ef76 Compare November 24, 2025 03:35

cthumuluru-crdb requested review from Nukitt, shubhamdhama and suj-krishnan November 24, 2025 06:51

cthumuluru-crdb marked this pull request as ready for review November 24, 2025 06:52

cthumuluru-crdb requested review from a team as code owners November 24, 2025 06:52

shubhamdhama reviewed Nov 24, 2025

View reviewed changes

rpc, server: add DRPC support for node join RPC #157993

Are you sure you want to change the base?

rpc, server: add DRPC support for node join RPC #157993

Uh oh!

Conversation

cthumuluru-crdb commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blathers-crl bot commented Nov 18, 2025

Uh oh!

cockroach-teamcity commented Nov 18, 2025

Uh oh!

github-actions bot commented Nov 18, 2025

Potential Bug(s) Detected

Uh oh!

github-actions bot commented Nov 20, 2025

Potential Bug(s) Detected

Uh oh!

github-actions bot commented Nov 20, 2025

Potential Bug(s) Detected

Uh oh!

github-actions bot commented Nov 20, 2025

Potential Bug(s) Detected

Uh oh!

github-actions bot commented Nov 24, 2025

Potential Bug(s) Detected

Uh oh!

github-actions bot commented Nov 24, 2025

Potential Bug(s) Detected

Uh oh!

shubhamdhama left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shubhamdhama Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

shubhamdhama Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

shubhamdhama Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

shubhamdhama Nov 24, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cthumuluru-crdb commented Nov 18, 2025 •

edited

Loading

shubhamdhama left a comment •

edited

Loading